build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26974 )
Change subject: sb/intel/lynxpoint: Get rid of device_t ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.... PS1, Line 660: static void pch_lpc_add_io_resource(struct device *dev, u16 base, u16 size, int index) line over 80 characters
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.... PS1, Line 673: static void pch_lpc_add_gen_io_resources(struct device *dev, int reg_value, int index) line over 80 characters
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.... PS1, Line 739: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.... PS1, Line 739: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.... File src/southbridge/intel/lynxpoint/pci.c:
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.... PS1, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.... PS1, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie... PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device) line over 80 characters
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie... PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie... PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata... PS1, Line 304: static void sata_enable(struct *dev) need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata... PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device) line over 80 characters
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata... PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata... PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watc... File src/southbridge/intel/lynxpoint/watchdog.c:
https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watc... PS1, Line 31: struct *dev; need consistent spacing around '*' (ctx:WxV)