Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 63:
(61 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/bb0b251f_d378eaab PS63, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/5dbb4e7c_e4c5da03 PS63, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/39cb10d9_508d15c2 PS63, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/ce5b9d65_d82dd505 PS63, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/a41bdd5a_3fea212f PS63, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/a824bade_54a032a5 PS63, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/fafccd29_cdd80648 PS63, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/2d42fc44_9e2b7346 PS63, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/445ed0a4_19b116a7 PS63, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/130b32e7_9ca2af8a PS63, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/a6ba8883_d7fa7aeb PS63, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/25dbcab9_eb1bf61c PS63, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/d11ef690_3536e5ac PS63, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/542864da_7497529a PS63, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/e85a2290_98c7958c PS63, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/a6e70188_7e8126e7 PS63, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/c1e0ba1c_2bb7abe6 PS63, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/4ac9aa6f_00bd37aa PS63, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/2038032a_75884070 PS63, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/7674fa24_69c459c9 PS63, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/ca050712_0748fc67 PS63, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/4b51c334_0501857c PS63, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/6c147ac7_8ad57bc0 PS63, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/be1ea5f8_4905cbe0 PS63, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/041bfcfa_34e29016 PS63, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/fd975a4c_064566ec PS63, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/9e4f34ca_33906fc7 PS63, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
File payloads/cbui/NuklearUI/NuklearRwNvram.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/400c6794_2ef01466 PS63, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/0583f38b_ff9be4a6 PS63, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/f0640b97_11ff4ef8 PS63, Line 89: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/687c80b8_fd5928d4 PS63, Line 93: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPciIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/7f7eee4b_e0ccb1b6 PS63, Line 156: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/b0df8b8d_cdc1f134 PS63, Line 159: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/b8e7efdd_0b0b937f PS63, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/2e7ed24d_fde32c92 PS63, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/c35024fa_14c0f150 PS63, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/b6f2fde1_5ab61fec PS63, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/ac2e9608_7f11a1c7 PS63, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/8c9fe94f_5d6223bc PS63, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/026147bb_db4dc2cf PS63, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/be3e02a0_dc177fac PS63, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/0f946369_695edbca PS63, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/b5c0ff8a_672c3d05 PS63, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/5b166890_8e5a9ae8 PS63, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/002d17e1_6bc3e26c PS63, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/e15e2b0d_527aad87 PS63, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/07ba8bef_84e38e92 PS63, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/2f167a68_3415f17a PS63, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/d8d359e5_cc7a76d3 PS63, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/d8520714_1151e328 PS63, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/4f3a936b_af795f1b PS63, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/c8ee5135_1fa63e88 PS63, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/533513f5_33e5f2e9 PS63, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/f3485f1a_24da311e PS63, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/d6341feb_63b866f0 PS63, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/6621e0bd_8a3b80f2 PS63, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/fcab3ae0_aa903ea2 PS63, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/6cbdb2bc_2e5aafca PS63, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/dd33a469_791dc7ce PS63, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/e75037e2_8750bc0a PS63, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159939): https://review.coreboot.org/c/coreboot/+/23586/comment/b8247fcd_b8055737 PS63, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const