Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40674 )
Change subject: arch/x86/acpi_device: Add a helper function to write PCI device
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c
File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c@...
PS2, Line 943: struct
This function can be used directly by . […]
Oh. You want to use it directly as acpi_fill_ssdt. Ya. That should be const. Do you want me to flip that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932af917d91198876fe8e90af9bb7a2531bd8960
Gerrit-Change-Number: 40674
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Apr 2020 22:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment