Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40248 )
Change subject: soc/amd/picasso/i2c: do not init I2C4 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40248/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40248/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/picasso/i2c: do not init I2C4 … as I2C host controller
https://review.coreboot.org/c/coreboot/+/40248/1/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40248/1/src/soc/amd/picasso/i2c.c@2... PS1, Line 23: * otherwise this slave device will not be able to work. Please re-flow for 96 characters.
I’d prefer if you left the member in there but commented out.