Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39005 )
Change subject: coreboot_tables: Support multiple framebuffers
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39005/6/src/lib/edid_fill_fb.c
File src/lib/edid_fill_fb.c:
https://review.coreboot.org/c/coreboot/+/39005/6/src/lib/edid_fill_fb.c@190
PS6, Line 190: set_bootsplash(fb_ptr, width, height, depth);
It would be good to make set_bootsplash cache the mapped CBFS file now that it can be called more than once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31c3da71ca0b96fb25219d6125c5f89d12157f74
Gerrit-Change-Number: 39005
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:07:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment