Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean up report_cpu_info() function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb...
File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb...
PS2, Line 170: "Platform info not available"
Could you please suggest on how i can handle this.
This is really just basic C programming...
Don't create a separate char pointer cpu_name and don't initialize the array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf7b04edc3fce147f7856591ce7e5a0cd05f43fe
Gerrit-Change-Number: 36840
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Nov 2019 11:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Usha P
usha.p@intel.com
Gerrit-MessageType: comment