Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 18: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... PS18, Line 415: use number of ways to prepare SF mask I think this comment should be on line 418 and the comment on line 418 should be here? When SF masks are not used, this comment doesn't really make sense here.
https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... PS18, Line 99: Are you planning to add a comment here indicating why masks are not programmed during teardown?