Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34754 )
Change subject: soc/intel/cannonlake: Add provision to skip postcar and load ramstage ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro... PS4, Line 133: * and car tear down will be handled by ramstage at its entry. This seems orthogonal to the change, and I'm not understanding why we need this. Presumably the same problem exists while loading postcar from romstage, but it's smaller so less noticeable?
https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro... PS4, Line 165: if (postcar_frame_init(&pcf, 0)) It should be noted somewhere that there's a stack being added that is only used for a very short amount of time but eating 4KiB.