Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41593 )
Change subject: AGESA f14 boards: Drop useless family definitions
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/inagua/bu...
File src/mainboard/amd/inagua/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/inagua/bu...
PS3, Line 15: #define INSTALL_FAMILY_14_SUPPORT TRUE
Can this be factored out?
I think I'll factor out in a follow-up. Otherwise I'll have to manually rebase the CB:41667 monster by hand... (it changes whitespace)
(and yes, I could have split it out a bit, but I started factoring things out at random, so it would have been a rather illogical series of commits... I'm a mess)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fc6ba94cde66a238da9705fc42330b9e7682800
Gerrit-Change-Number: 41593
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 May 2020 21:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment