John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/acpi/usbc.asl:
PS1:
Sounds good!
Drop "chip drivers/intel/pmc" since pmc is hidden and resource is inaccessible. Back to Caveh's "drivers/intel/tcss" through xhci's device ID "PCI_DEVICE_ID_INTEL_TGP_TCSS_XHCI -> 0x9A13".
USB properties of usb2-port-number/usb3-port-number/sbu-orientation/hsl-orientation are assigned from devicetree's xhci(00.0d.00). With the generated SSDT PMC.MUX.CONx along with SSDT LPCB.EC0.CREC.USBC, the preliminary test shows USBC(GOOG0014) and PMC(INTC1026) are probed successfully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b443a1ca1c5361652a69586b340b1c95e9c3f06
Gerrit-Change-Number: 40425
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Mon, 27 Apr 2020 15:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment