Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32112 )
Change subject: vboot: Change oprom checks to CONFIG_VBOOT, assert OPROM_MATTERS ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c File src/lib/bootmode.c:
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c@38 PS3, Line 38: Chrome OS
vboot
Done
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c@42 PS3, Line 42: dead_code
No strong opinion here in any way, but that name is confusing me in this context. […]
Sure, that sounds fine too... feel free to upload a CL to rename it if you want. But this patch is just using the existing macro (and there are other uses in the repo) so I can't rename it here.