Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36428 )
Change subject: arch/acpi.h: Use of typedef for acpi_spmi
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36428/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36428/1//COMMIT_MSG@7
PS1, Line 7: arch/acpi.h: Use of typedef for acpi_spmi
Please make it a statement by using a verb (in imperative mood).
Use typedef for acpi_spmi
https://review.coreboot.org/c/coreboot/+/36428/1//COMMIT_MSG@9
PS1, Line 9: Use of
Use
https://review.coreboot.org/c/coreboot/+/36428/1//COMMIT_MSG@10
PS1, Line 10:
Please elaborate, why this conversion is a good idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab59f26a4f069efb991fa3d077a5bbae78d90bdc
Gerrit-Change-Number: 36428
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Nov 2019 16:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment