[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/braswell/hda.c: Configure HDA codecs

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29394 )

Change subject: src/soc/intel/braswell/hda.c: Configure HDA codecs
......................................................................

Patch Set 8:
> Patch Set 8:
>
> since LPE audio is the norm on braswell devices, might it be better to set a Kconfig for HDA audio and conditionally include hda_verb.c if set?  That way you don't need to modify existing boards which don't use HDA audio.

For sure Kconfig can be used. I'm not sure if the PCI configuration of the HDA will changefor boards which have 'HDA disabled' in Kconfig. It will remove the read/set/enable of the HDA controller.