29 Nov
2019
29 Nov
'19
11:15 a.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock ......................................................................
Patch Set 18:
Patch Set 18:
Patch Set 18:
Patch Set 18:
I wasn't really able to communicate in the review how I wanted to split this commit into several pieces. If you think we can make CB:37353 work, I would submit it with the Change-Id of this one.
No problem. Should I abandon this one or will it break the chain?
Don't abandon, I will reuse the change-id to keep all the reviews around. Iff CB:37353 works out.
Pushed new patchset to CB:37353 and applied CB:36915 on top of that. Small fix and works now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29916a96f490ff717c69dc7cd565d74a83dbfb0d
Gerrit-Change-Number: 36914
Gerrit-PatchSet: 18
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Mike Banon mikebdp2@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 11:15:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment