Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40295 )
Change subject: soc/amd/psp: Add SmmInfo command
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40295/6/src/soc/amd/common/block/ps...
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/40295/6/src/soc/amd/common/block/ps...
PS6, Line 156: 0xfffff000
good question why it's made sure here that the mask is set in a way that the granularity is at least […]
this masks SMM_LOCK and SMM_TSEG_VALID, but not SMM_TSEG_WB. needs more investigation; I'd suspect that this should be 0xffff0000 instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10088a53e786db788740e4b388650641339dae75
Gerrit-Change-Number: 40295
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 12:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment