Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )
Change subject: inteltool: Move GPIOs to c files per platform
......................................................................
Patch Set 34:
(2 comments)
https://review.coreboot.org/#/c/31504/34/util/inteltool/gpio.h
File util/inteltool/gpio.h:
PS34:
Why mix these two different models in one file?
No specific reason. Both seperated seems a bit small to me, but not really a problem.
https://review.coreboot.org/#/c/31504/34/util/inteltool/platform_apollolake....
File util/inteltool/platform_apollolake.h:
PS34:
You don't need one header file per platform. You could gather the declarations […]
What is a compilation unit? I want to implement more registers in the future, so they will also be included in other c files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic61871f5cf95ac3da93892fa2f7721e682176c8d
Gerrit-Change-Number: 31504
Gerrit-PatchSet: 34
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marius Genheimer
mail@f0wl.cc
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 08 May 2019 13:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
