Attention is currently required from: ChrisEric1 CECL.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71999 )
Change subject: src/mainboard/dell/inspiron_*: Add Support for Dell Inspiron 620 & 3847 ......................................................................
Patch Set 2:
(10 comments)
Commit Message:
PS2: Please re-flow for 72 characters per line, and please add a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/71999/comment/74d86aa7_ba9f4c71 PS2, Line 7: Support support
https://review.coreboot.org/c/coreboot/+/71999/comment/2897c96c_81d59302 PS2, Line 7: src/mainboard mb
https://review.coreboot.org/c/coreboot/+/71999/comment/4fd84c96_c4bb2948 PS2, Line 9: . (using Autoport) No brackets: … using autoport.
https://review.coreboot.org/c/coreboot/+/71999/comment/8ecf4ede_1f59757a PS2, Line 9: Initial Support initial support
https://review.coreboot.org/c/coreboot/+/71999/comment/648d4a67_7fb693f8 PS2, Line 9: Add Initial Support for Dell Inspiron 620 and Dell Inspiron 3847. (using Autoport) Maybe extend that paragraph stating the chipset of the boards.
https://review.coreboot.org/c/coreboot/+/71999/comment/049c47a1_1dc305ae PS2, Line 10: UEFI What does “UEFI” mean? The vendor system firmware, or the EDK2/TianoCore payload?
https://review.coreboot.org/c/coreboot/+/71999/comment/a1649a0b_6c95a037 PS2, Line 12: Patch patch
https://review.coreboot.org/c/coreboot/+/71999/comment/40791e6b_4e01dca2 PS2, Line 12: Works works
Patchset:
PS2: Welcome to coreboot! You contribution is much appreciated.
It’s common practice to make one commit per board. Would that be possible?