build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37451 )
Change subject: [WIP] hudson_lpc_port80 ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 80: if (CONFIG(POST_DEVICE_PCI_PCIE)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 80: if (CONFIG(POST_DEVICE_PCI_PCIE)) suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 81: hudson_pci_port80(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 81: hudson_pci_port80(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 82: else if (CONFIG(POST_DEVICE_LPC)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 82: else if (CONFIG(POST_DEVICE_LPC)) suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 83: hudson_lpc_port80(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37451/4/src/southbridge/amd/agesa/h... PS4, Line 83: hudson_lpc_port80(); please, no spaces at the start of a line