HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )
Change subject: mb/{kontron,supermicro}: Use pcidev_on_root()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10...
File src/mainboard/supermicro/h8scm_fam10/mptable.c:
https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10...
PS2, Line 48: pirq_router_bus TODO: why bus_sp5100[0] use same value of
: * bus_sr5650[0] assigned by get_pci1234(), instead of 0.
This comment is more confusing after the reformatting. I'm not too […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57
Gerrit-Change-Number: 31051
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Jan 2019 10:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment