Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39318 )
Change subject: chromeos: stop sharing write protect GPIO with depthcharge ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39318/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39318/1//COMMIT_MSG@17 PS1, Line 17: Change-Id: I2fcb7f82aa063fd72928171af5cbef0356ba620c Probably better to insert a
Cq-Depend: chromium:2088434
here while the other patch hasn't landed yet. It won't make a difference for coreboot.org, but it will work when Patrick picks this back into our tree.
https://review.coreboot.org/c/coreboot/+/39318/1/src/mainboard/google/auron/... File src/mainboard/google/auron/chromeos.c:
https://review.coreboot.org/c/coreboot/+/39318/1/src/mainboard/google/auron/... PS1, Line 33: int get_write_protect_state(void) We should get rid of this function everywhere too, it is no longer needed. The only use is in mrc_cache.c, and I don't really think it is needed there (should do that in a separate patch so the x86 experts can chime in on that).