Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39639 )
Change subject: Revert "src/mb/google/volteer: Add camera ACPI configuration"
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
The patch was for temporary use until we completely move to SSDT. The temporal DSDT patch is needed for camera validation and power on works. I'll revert it once SSDT patch is merged.
1. It was already communicated that the static ASL change will not be merged upstream. It was supposed to be cherry-picked for any validation/testing.
2. In the future, can you please ensure that the CLs that you push for volteer/tgl have nvaccaro@ and caveh@ as reviewers.
3. mipi_camera.asl needs a number of clean ups.
Do you have an ETA on when SSDT changes would be ready?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c5cbb8ae057771191fb80ec1a1768e0e817b890
Gerrit-Change-Number: 39639
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Mar 2020 02:56:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment