build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48322 )
Change subject: Revert "util: Remove 'getpir' and 'mptable' tools" ......................................................................
Patch Set 3:
(65 comments)
File util/getpir/README:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/04e0a15a_6b22aa68 PS3, Line 25: edit irq_tables.c manualy and replace checksum. 'manualy' may be misspelled - perhaps 'manually'?
File util/getpir/checkpir.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/b12dee08_0a900200 PS3, Line 23: printf("Checksum for IRQ Routing table is ok. You can use irq_tables.c in coreboot now.\n"); line over 96 characters
File util/getpir/checksum.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/23ea6bdc_0e65a724 PS3, Line 12: return (sum); return is not a function, parentheses are not required
File util/getpir/code_gen.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/6ce04cab_9629e6db PS3, Line 23: " * along with this program; if not, write to the Free Software\n", Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/fa45ed64_b2d9119c PS3, Line 24: " * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA\n", Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/cf9363ea_8036b668 PS3, Line 65: fprintf(fpir, "\t%#x, /* Checksum (has to be set to some value that\n * would give 0 after the sum of all bytes\n * for this structure (including checksum).\n */\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/f80e0b98_34cf7878 PS3, Line 68: fprintf(fpir, "\t\t/* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */\n"); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/acca9960_f2d53e10 PS3, Line 70: fprintf(fpir, "\t\t{0x%02x, (0x%02x << 3) | 0x%01x, {{0x%02x, 0x%04x}, {0x%02x, 0x%04x}, {0x%02x, 0x%04x}, {0x%02x, 0x%04x}}, 0x%x, 0x%x},\n", line over 96 characters
File util/getpir/getpir.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/4053aa68_95f347ff PS3, Line 23: #if defined (__sun) && (defined(__i386) || defined(__amd64)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/75c82d5b_d2501e60 PS3, Line 37: static struct irq_routing_table *probe_table(char* ptr) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/b1a3eba8_df8862b2 PS3, Line 58: printf("Found PCI IRQ routing table signature at %p.\n", (void *) ((char *) rt - ptr + 0xf0000)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/acb5cf4a_ef3f64d9 PS3, Line 59: printf("SIGNATURE = %s\n", (char*)&rt->signature); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/b3dff263_d951166a PS3, Line 64: printf("INT_ROUTER DEVICE = (0x%02x << 3) | 0x%01x\n", rt->rtr_devfn >> 3, rt->rtr_devfn & 7); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/2b8476a8_5d22e3d9 PS3, Line 70: printf("\tbus , dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu\n"); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/55ec9959_ba07ec21 PS3, Line 70: printf("\tbus , dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/4277205a_b86376ca PS3, Line 70: printf("\tbus , dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu\n"); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/18a8d098_9316c7a3 PS3, Line 70: printf("\tbus , dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/2a896d8b_74fd8208 PS3, Line 72: printf("\t0x%02x, (0x%02x << 3) | 0x%01x, {{0x%02x, 0x%04x}, {0x%02x, 0x%04x}, {0x%02x, 0x%04x}, {0x%02x, 0x%04x}}, 0x%x, 0x%x},\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/2a7cf4d9_f67e5c16 PS3, Line 73: (se_arr+i)->bus, (se_arr+i)->devfn >> 3, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/ec4324ac_3390c78f PS3, Line 73: (se_arr+i)->bus, (se_arr+i)->devfn >> 3, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/de6c324b_b63d7003 PS3, Line 74: (se_arr+i)->devfn & 7, (se_arr+i)->irq[0].link, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/7a91fdbc_d780d9b8 PS3, Line 75: (se_arr+i)->irq[0].bitmap, (se_arr+i)->irq[1].link, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/1352286d_3b1621d4 PS3, Line 76: (se_arr+i)->irq[1].bitmap, (se_arr+i)->irq[2].link, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/8acb3216_2a1adbe9 PS3, Line 77: (se_arr+i)->irq[2].bitmap, (se_arr+i)->irq[3].link, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/7a649f34_9fe8db76 PS3, Line 78: (se_arr+i)->irq[3].bitmap, (se_arr+i)->slot, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/3c0c9eca_0f93a507 PS3, Line 82: if (rt->size > 0x400) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/e343d496_4c5050d1 PS3, Line 89: printf("CHECKSUM = %#x\n", 0x100-((checksum_result - rt->checksum) & 0xFF)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/b0b755ee_f8566b08 PS3, Line 109: int main(int argc, char* argv[]) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/ed298d96_0c27dc62 PS3, Line 111: char* ptr; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/97cd436f_9e9fafe9 PS3, Line 113: struct irq_routing_table* rt = NULL; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/28270747_dfb29413 PS3, Line 114: void* bios_image = NULL; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/d6cdd8b8_ecf2275d PS3, Line 115: if ( argc > 1 ) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/ffb797b9_8459d907 PS3, Line 115: if ( argc > 1 ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/d6aec200_08b6442e PS3, Line 115: if ( argc > 1 ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/a7cb74a6_f1229526 PS3, Line 117: /** there a paramater passed to the program, assume that it is a menory file */ 'paramater' may be misspelled - perhaps 'parameter'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/650a0170_ad26558e PS3, Line 132: ptr = (char*)bios_image; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/779b27dd_8fed1c2e PS3, Line 144: /** No paramaters means that the program will access the system memory */ 'paramaters' may be misspelled - perhaps 'parameters'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/8701a6b2_412b5cf9 PS3, Line 163: return (1); return is not a function, parentheses are not required
File util/getpir/pirq_routing.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/11644918_3fb5e071 PS3, Line 12: uint8_t link; /* IRQ line ID, chipset dependent, 0=not routed */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/f601fd24_41ac5a5b PS3, Line 46: #if CONFIG_HAVE_PIRQ_TABLE==1 spaces required around that '==' (ctx:VxV)
File util/mptable/mptable.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/9200befc_ac6c9530 PS3, Line 53: #define ARRAY_SIZE(_x) (sizeof(_x) / sizeof(_x[0])) Prefer ARRAY_SIZE(_x)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/55e78f4b_01f3aada PS3, Line 149: {129, 8, "Bus Heirarchy"}, 'Heirarchy' may be misspelled - perhaps 'Hierarchy'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/7fcf85de_65e6b1fe PS3, Line 251: static void apic_probe(vm_offset_t * paddr, int *where); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/09c9e1dd_e27dacce PS3, Line 255: static void MPFloatingPointer(vm_offset_t paddr, int where, mpfps_t * mpfps); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/0575d29e_0ea03119 PS3, Line 274: static void pnstr(uint8_t * s, int c); "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/66898548_558b402d PS3, Line 340: "usage: mptable [-dmesg] [-verbose] [-grope] [-help]\n"); Prefer using '"%s...", __func__' to using 'usage', this function's name, in a string
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/9b290c8a_813a1dcc PS3, Line 373: if (strcmp(argv[0], "-dmesg") == 0) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/9914a804_992ab843 PS3, Line 437: static void apic_probe(vm_offset_t * paddr, int *where) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/7d95d3cc_7ee25987 PS3, Line 597: static void MPFloatingPointer(vm_offset_t paddr, int where, mpfps_t * mpfps) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/0fb85a1f_8c9a38d5 PS3, Line 788: /* initialze tables */ 'initialze' may be misspelled - perhaps 'initialize'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/d51d32fa_0b84acd4 PS3, Line 789: for(x = 0; x < ARRAY_SIZE(busses); x++) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/8ad9165f_67f7422b PS3, Line 791: for(x = 0; x < ARRAY_SIZE(apics); x++) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/17286b3f_fc434f40 PS3, Line 827: printf("\t/* I/O Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN#*/ \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/566f43cd_0def3275 PS3, Line 843: #if defined( EXTENDED_PROCESSING_READY ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/2ed9a456_1a260466 PS3, Line 843: #if defined( EXTENDED_PROCESSING_READY ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/e87476ad_da16d4c6 PS3, Line 874: #if defined( OEM_PROCESSING_READY ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/6d54a098_8d6f1cae PS3, Line 874: #if defined( OEM_PROCESSING_READY ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/4cb5b82e_b3e7a754 PS3, Line 897: #if defined( RAW_DUMP ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/88dc0ffe_2980e22a PS3, Line 897: #if defined( RAW_DUMP ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/f0b5d30d_8394ef43 PS3, Line 961: cpuFlags & PROCENTRY_FLAG_EN) ? "usable" : "unusable"); Avoid multiple line dereference - prefer 'entry.cpuFlags'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/71fa23c4_87694419 PS3, Line 1005: for(i = 0; i < 6; i++) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/957c1656_5f5999c2 PS3, Line 1006: switch(entry.busType[i]) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/bf779fb1_6dc17204 PS3, Line 1042: apicFlags & IOAPICENTRY_FLAG_EN) ? "usable" : Avoid multiple line dereference - prefer 'entry.apicFlags'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/8e2c5ad4_43587108 PS3, Line 1099: printf("\tsmp_write_intsrc(mc, %s, %s|%s, 0x%x, (0x%02x << 2) | INT%c, 0x%x, 0x%x);\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131540): https://review.coreboot.org/c/coreboot/+/48322/comment/18cc13d9_7481e8b4 PS3, Line 1249: static void pnstr(uint8_t * s, int c) "foo * bar" should be "foo *bar"