Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42194 )
Change subject: soc/mediatek/mt8183: Adjust tRFCab and tRFCpb by the density value ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42194/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42194/2//COMMIT_MSG@10 PS2, Line 10:
Were errors seen before this?
this purpose of patch is to support 6GB,8GB DDR.
https://review.coreboot.org/c/coreboot/+/42194/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/42194/2/src/soc/mediatek/mt8183/dra... PS2, Line 2711: void
I think it's fine to directly return the density here, but it's up to you.
Done
https://review.coreboot.org/c/coreboot/+/42194/2/src/soc/mediatek/mt8183/dra... PS2, Line 2714: size_Gb
size_gb
Done