Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32233 )
Change subject: chromeos: clean up "recovery" and "write protect" GPIOs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32233/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32233/1//COMMIT_MSG@18 PS1, Line 18: Most of these inaccuracies are from : non-inverted values on ACTIVE_LOW GPIOs. For the GPIOs that had the incorrect values because of ACTIVE_LOW nature of GPIOs, can the entry be in lb_gpio table be set to { -1, ACTIVE_HIGH, get_write_protect_state, "write protect" }, or { -1, ACTIVE_HIGH, get_recovery_mode_switch, "recovery" },
This ensures that: 1. -1 --> No resampling in coreboot 2. ACTIVE_HIGH --> No need to remember to invert the values which are already returning the value of the switch correctly by taking the polarity into account.