Hello Aaron Durbin, Daisuke Nojiri, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31626
to look at the new patch set (#2).
Change subject: google_chromeec_command: makes the error status consistent ......................................................................
google_chromeec_command: makes the error status consistent
Currently within various google_chromeec_command() implementation the error can be returned differently (LPC: -1 for v3, 1 for v1, SPI: -1/1, I2C: 1). This patch attempts to make it consistent across all implementations by using only negative number as error.
All direct/indirect callers of google_chromeec_command() have already checked for non-zero value so no modification is needed.
BRANCH=None BUG=chromium:935038
Signed-off-by: YH Lin yueherngl@google.com Change-Id: I39f12502bc6982670dd200dcef0724e7eed2ed29 --- M src/ec/google/chromeec/crosec_proto.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_i2c.c M src/ec/google/chromeec/ec_lpc.c 4 files changed, 17 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31626/2