YH Lin uploaded patch set #2 to this change.

View Change

google_chromeec_command: makes the error status consistent

Currently within various google_chromeec_command() implementation
the error can be returned differently (LPC: -1 for v3, 1 for v1,
SPI: -1/1, I2C: 1). This patch attempts to make it consistent across
all implementations by using only negative number as error.

All direct/indirect callers of google_chromeec_command() have
already checked for non-zero value so no modification is needed.

BRANCH=None
BUG=chromium:935038

Signed-off-by: YH Lin <yueherngl@google.com>
Change-Id: I39f12502bc6982670dd200dcef0724e7eed2ed29
---
M src/ec/google/chromeec/crosec_proto.c
M src/ec/google/chromeec/ec.h
M src/ec/google/chromeec/ec_i2c.c
M src/ec/google/chromeec/ec_lpc.c
4 files changed, 17 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31626/2

To view, visit change 31626. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39f12502bc6982670dd200dcef0724e7eed2ed29
Gerrit-Change-Number: 31626
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin <yueherngl@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: YH Lin <yueherngl@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: newpatchset