EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48526 )
Change subject: util: Modify LPDDR4 spd_tools to generate SPDs for ADL boards
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Will add mem_list_variant if we decide the memory part for brya. So far, it include in the global_lp4x_mem_parts.json,already.
We need to generate SPD files for soc/intel/alderlake. I am thinking that we should just move the SPDs to a common place rather than in each SoC. Not for this change, but I think that will help simplify the SPD generation and management.
+1,maybe 3rdparty/blobs is the good place to put into?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4964ec28d74ab36c6b6f2e9dce6c923d1df95c84
Gerrit-Change-Number: 48526
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 07:23:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment