[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Move common definitions to a header file

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31621 )

Change subject: soc/intel/cannonlake: Move common definitions to a header file
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31621/1/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/gpio_common.h:

https://review.coreboot.org/#/c/31621/1/src/soc/intel/cannonlake/include/soc... 
PS1, Line 15: #ifndef _SOC_CANNONLAKE_GPIO_COMMON_H_
            : #define _SOC_CANNONLAKE_GPIO_COMMON_H_
please add empty lines around these