Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41368 )
Change subject: nb/intel/i440bx: add resources during read_resources() ......................................................................
Patch Set 2:
Patch Set 2:
Here are the i440BX limits:
Max 1GB RAM Max 4 DIMM slots 4 DIMM slots only supported using registered DIMMs Max 256MB per DIMM (and of the x8 type only; the kind that has 256MB with chips on one side only are not supported, although our ram init can use them partially.)
So, without registered DIMMs, the most memory "i can haz" is 768MB, which is what I'm testing with.
Thanks, Keith, for the info. find_pci_tolm() is still wrong based on my understanding of the chipset in that the register will reflect the correct answer since DRB7 << 23 can maximally be 1GiB.