Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46314 )
Change subject: soc/intel/skylake: Add chipset devicetree ......................................................................
Patch Set 5:
(5 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... File src/soc/intel/skylake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... PS2, Line 8: device pci 04.0 alias sa_thermal off end # SA thermal subsystem
should be enabled by default (linux reads the tcc value from that device)
defaults can be discussed in another patch.
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... PS2, Line 14: device pci 14.2 alias thermal off end # Thermal Subsystem
should be enabled by default
Done
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... PS2, Line 20: heci1
hmm, iirc this needs to be on so cb can initialize me. […]
Done
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... PS2, Line 60: pch_espi
lpc_espi maybe?
Done
https://review.coreboot.org/c/coreboot/+/46314/2/src/soc/intel/skylake/chips... PS2, Line 65: on
could be "hidden" by default
Done