Attention is currently required from: Anand Vaikar, Paul Menzel, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80701?usp=email )
Change subject: soc/amd/glinda: Update GPP_CLK_OUTPUT_AVAILABLE ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80701/comment/3b87d9b1_0a8e3c17 : PS1, Line 7: Update GPP_CLK_OUTPUT_AVAILABLE
Please be more specific: […]
i'd say that the 7 is the only relevant number here. the 4 is from mendocino and iirc glinda started as copy of mendocino
https://review.coreboot.org/c/coreboot/+/80701/comment/94b7481e_acbcd698 : PS1, Line 10: Reference (PPR) (#57254), table 230.
would be good to mention the revision of that document; in the revision i'm looking at, it's a diffe […]
or just refer to the table by its name "GPP ClkREQB Mapping"
Patchset:
PS1:
Is that a copy and paste error, or was PPR updated?
i'd guess that in some version there were a few more tables added, so the numbers shifted