Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/include/soc/ubox.h:
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell...
PS4, Line 44: static inline void iio_hide(uint8_t devno, uint8_t funcno)
const
Ack
https://review.coreboot.org/c/coreboot/+/35321/4/src/soc/intel/fsp_broadwell...
PS4, Line 50: reg = pci_mmio_read_config32(ubox_dev, UBOX_DEVHIDE0 + (funcno * 4));
brackets not neccessary
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fcac5b7d9a7a52a2801c010bfccf247f2a44581
Gerrit-Change-Number: 35321
Gerrit-PatchSet: 8
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 22:20:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment