Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36915 )
Change subject: mb/pcengines/apu2: move to C bootblock ......................................................................
Patch Set 28:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36915/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36915/27//COMMIT_MSG@7 PS27, Line 7: mb/pcengines/apu2: move to C bootblock pcengines/apu2: Switch away from ROMCC_BOOTBLOCK
Just to be consistent with previous BINARYPI_LEGACY_WRAPPER titles.
https://review.coreboot.org/c/coreboot/+/36915/28/src/mainboard/pcengines/ap... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/36915/28/src/mainboard/pcengines/ap... PS28, Line 41: pm_io_write8(0xea, 1); pm_write8() now that ACPIMMIO is enabled in bootblock already?
Is there still PCI-PCI bridge 0:14.4 (?), I see this comment has origins in fam16kb.