Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email )
Change subject: lib: Explicitly declare heap as NOLOAD ......................................................................
lib: Explicitly declare heap as NOLOAD
The GNU BFD linker makes a good guess that this section should not be loaded, however other linkers like LLVM LD need this to be made explicit in order for the section to have the NOBITS, rather than PROGBITS attribute set.
Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/80735 Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/lib/program.ld 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Maximilian Brune: Looks good to me, approved
diff --git a/src/lib/program.ld b/src/lib/program.ld index 21f4be8..6d72d9e 100644 --- a/src/lib/program.ld +++ b/src/lib/program.ld @@ -131,7 +131,7 @@ #endif
#if ENV_HAS_HEAP_SECTION -.heap . : { +.heap . (NOLOAD) : { . = ALIGN(ARCH_POINTER_ALIGN_SIZE); _heap = .; . += CONFIG_HEAP_SIZE;