[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add support for LPSS UART in ACPI mode

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )

Change subject: soc/intel/common: Add support for LPSS UART in ACPI mode
......................................................................

Patch Set 19:

(4 comments)

https://review.coreboot.org/c/coreboot/+/40405/18//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40405/18//COMMIT_MSG@9 
PS18, Line 9: Add support for LPSS UART in ACPI mode.
> Since this is the same as the commit summary, I'd drop it

Done

https://review.coreboot.org/c/coreboot/+/40405/18//COMMIT_MSG@12 
PS18, Line 12: the PCI devices is still operating
> but the PCI devices still operate

Done

https://review.coreboot.org/c/coreboot/+/40405/18//COMMIT_MSG@15 
PS18, Line 15: devices IDs
> device IDs

Done

https://review.coreboot.org/c/coreboot/+/40405/18/src/soc/intel/common/block... 
File src/soc/intel/common/block/uart/uart.c:

https://review.coreboot.org/c/coreboot/+/40405/18/src/soc/intel/common/block... 
PS18, Line 230: !CONFIG(SOC_INTEL_TIGERLAKE)
> maybe add a new Kconfig symbol? SOC_INTEL_COMMON_BLOCK_UART_SSDTGEN

Dropped