Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35306 )
Change subject: soc/intel/cannonlake: Add config for sata devslp pad reset configuration ......................................................................
soc/intel/cannonlake: Add config for sata devslp pad reset configuration
CML FSP now provides a provision to configure the SATA devslp GPIO pad reset configuration. This config would help set the the required pad reset configuration.
BUG=b:133000685
Change-Id: I4eaea9c6da67f1274ad3e392046a68cddc1b99b6 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35306 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/fsp_params.c 2 files changed, 15 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved V Sowmya: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 2ebe017..9c7c171 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -136,9 +136,19 @@ Sata_AHCI, Sata_RAID, } SataMode; + + /* SATA devslp pad reset configuration */ + enum { + SataDevSlpResumeReset = 1, + SataDevSlpHostDeepReset = 3, + SataDevSlpPlatformReset = 5, + SataDevSlpDswReset = 7 + } SataDevSlpRstConfig; + uint8_t SataSalpSupport; uint8_t SataPortsEnable[8]; uint8_t SataPortsDevSlp[8]; + uint8_t SataPortsDevSlpResetConfig[8];
/* Enable/Disable SLP_S0 with GBE Support. 0: disable, 1: enable */ uint8_t SlpS0WithGbeSupport; diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index 4038335..f48a626 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -186,6 +186,11 @@ sizeof(params->SataPortsEnable)); memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp, sizeof(params->SataPortsDevSlp)); +#if CONFIG(SOC_INTEL_COMETLAKE) + memcpy(params->SataPortsDevSlpResetConfig, + config->SataPortsDevSlpResetConfig, + sizeof(params->SataPortsDevSlpResetConfig)); +#endif }
/* Lan */