Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42521/1/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/42521/1/src/mainboard/pcengines/apu... PS1, Line 16: return gpio0_read32(gpio & 0x3ff);
There are sane and insane developers, you know :) […]
Yes, sorry. As before in my other comments it was about maintaining proper API and abstractions. Anything in src/mainboard shouldn't be adding code to maintaining the boundary conditions of the chipset. We should provide the proper abstractions in chipset code to make mainboard ports easier. I'll try to be more clear in the future, but I'd really like to remove most of this chipset specific code from mainboard and provide the semantics desired from mainboard.