Name of user not set #1002701 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37532 )
Change subject: northbridge: Don't use both of _ADR and _HID
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(1 comment)
For my it's OK, I was only using an already present patch.
https://review.coreboot.org/c/coreboot/+/37532/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37532/1//COMMIT_MSG@7
PS1, Line 7: {northbridge,soc,southbridge}: Don't use both of _ADR and _HID
I believe he used CB:36318 but only kept one file.
Yes, the code and comment is from that commit. Should I redo the comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48fb3e9e48893336416eb90f80957e5bd21d1711
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002701
Gerrit-Reviewer: Name of user not set #1002701
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 10:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment