Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37863 )
Change subject: mb/intel/tglrvp : Add MIPI Camera ACPI ......................................................................
mb/intel/tglrvp : Add MIPI Camera ACPI
Add MIPI Camera ACPI for enabling Camera
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board and check Camera
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I4189e96f68f0e64e0860405e00eeab84564b86be --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/dsdt.asl 2 files changed, 53 insertions(+), 52 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/37863/1
diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl old mode 100644 new mode 100755 index bd2727e..030b6b5 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -17,14 +17,14 @@ { Device (IPU0) { - Name (_ADR, 0x00050000) // _ADR: Address - Name (_DDN, "Camera and Imaging Subsystem") // _DDN: DOS Device Name + Name (_ADR, 0x00050000) + Name (_DDN, "Camera and Imaging Subsystem") } }
Scope (_SB.PCI0.IPU0) { - Name (_DSD, Package (0x02) // _DSD: Device-Specific Data + Name (_DSD, Package (0x02) { ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), Package (0x02) @@ -181,41 +181,40 @@ PowerResource (RCPR, 0x00, 0x0000) { Name (STA, Zero) - Method (_ON, 0, Serialized) // _ON_: Power On + Method (_ON, 0, Serialized) { If ((STA == Zero)) { - // Enable CLK0 - MCCT(0,1,1) // Clock 0, enable, 19.2MHz - // Pull PWREN(GPIO B23) high + /* Enable CLK0 with 19.2MHz */ + MCCT(0,1,1) + /* Pull PWREN(GPIO B23) high */ STXS(GPP_B23) Sleep(5) - // Pull RST(GPIO C15) low + /* Pull RST(GPIO C15) low */ CTXS(GPP_C15) Sleep(5) - // Pull RST high + /* Pull RST high */ STXS(GPP_C15) Sleep(5) Store(1,STA) } }
- Method (_OFF, 0, Serialized) // _OFF: Power Off + Method (_OFF, 0, Serialized) { If ((STA == One)) { - // Pull RST low + /* Pull RST low */ CTXS(GPP_C15) - // Pull PWREN low + /* Pull PWREN low */ CTXS(GPP_B23) - // Disable CLK0 - MCCT(0,0,1) // Clock 0, disable, 19.2MHz - // STA = Zero + /* Disable CLK0 */ + MCCT(0,0,1) Store(0,STA) } }
- Method (_STA, 0, NotSerialized) // _STA: Status + Method (_STA, 0, NotSerialized) { Return (STA) } @@ -223,15 +222,15 @@
Device (CAM0) { - Name (_HID, "OVTI8856") // _HID: Hardware ID - Name (_UID, Zero) // _UID: Unique ID - Name (_DDN, "Ov 8856 Camera") // _DDN: DOS Device Name - Method (_STA, 0, NotSerialized) // _STA: Status + Name (_HID, "OVTI8856") + Name (_UID, Zero) + Name (_DDN, "Ov 8856 Camera") + Method (_STA, 0, NotSerialized) { Return (0x0F) }
- Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + Name (_CRS, ResourceTemplate () { I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, AddressingMode7Bit, "\_SB.PCI0.I2C3", @@ -239,17 +238,17 @@ ) })
- Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 + Name (_PR0, Package (0x01) { RCPR })
- Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot + Name (_PR3, Package (0x01) { RCPR })
- Name (_DSD, Package (0x04) // _DSD: Device-Specific Data + Name (_DSD, Package (0x04) { ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), Package (0x01) @@ -338,34 +337,34 @@
Device (VCM0) { - Name (_HID, "PRP0001") // _HID: Hardware ID - Name (_UID, 0x03) // _UID: Unique ID - Name (_DDN, "DW9714 VCM") // _DDN: DOS Device Name - Method (_STA, 0, NotSerialized) // _STA: Status + Name (_HID, "PRP0001") + Name (_UID, 0x03) + Name (_DDN, "DW9714 VCM") + Method (_STA, 0, NotSerialized) { Return (0x0F) }
- Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + Name (_CRS, ResourceTemplate () { I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80, AddressingMode7Bit, "\_SB.PCI0.I2C3", 0x00, ResourceConsumer, , ) }) - Name (_DEP, Package (0x01) // _DEP: Dependencies + Name (_DEP, Package (0x01) { CAM0 }) - Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 + Name (_PR0, Package (0x01) { RCPR }) - Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot + Name (_PR3, Package (0x01) { RCPR }) - Name (_DSD, Package (0x02) // _DSD: Device-Specific Data + Name (_DSD, Package (0x02) { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package (0x01) @@ -385,35 +384,35 @@ PowerResource (FCPR, 0x00, 0x0000) { Name (STA, Zero) - Method (_ON, 0, Serialized) // _ON_: Power On + Method (_ON, 0, Serialized) { If ((STA == Zero)) { - // Enable CLK1 - MCCT(1,1,1) // Clock 1, enable, 19.2MHz - // Pull PWREN(GPIO R6) high + /* Enable CLK1 with 19.2MHz */ + MCCT(1,1,1) + /* Pull PWREN(GPIO R6) high */ STXS(GPP_R6) Sleep(5) - // Pull RST(GPIO H12) low + /* Pull RST(GPIO H12) low */ CTXS(GPP_H12) Sleep(5) - // Pull RST high + /* Pull RST high */ STXS(GPP_H12) Sleep(5) Store(1,STA) } }
- Method (_OFF, 0, Serialized) // _OFF: Power Off + Method (_OFF, 0, Serialized) { If ((STA == One)) { - // Pull RST low + /* Pull RST low */ CTXS(GPP_H12) - // Pull PWREN low + /* Pull PWREN low */ CTXS(GPP_R6) - // Disable CLK0 - MCCT(1,0,1) // Clock 1, disable, 19.2MHz + /* Disable CLK1 */ + MCCT(1,0,1) Store(0,STA) } } @@ -426,15 +425,15 @@
Device (CAM1) { - Name (_HID, "OVTI8856") // _HID: Hardware ID - Name (_UID, Zero) // _UID: Unique ID - Name (_DDN, "Ov 8856 Camera") // _DDN: DOS Device Name - Method (_STA, 0, NotSerialized) // _STA: Status + Name (_HID, "OVTI8856") + Name (_UID, Zero) + Name (_DDN, "Ov 8856 Camera") + Method (_STA, 0, NotSerialized) { Return (0x0F) }
- Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + Name (_CRS, ResourceTemplate () { I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, AddressingMode7Bit, "\_SB.PCI0.I2C5", @@ -442,17 +441,17 @@ ) })
- Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 + Name (_PR0, Package (0x01) { FCPR })
- Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot + Name (_PR3, Package (0x01) { FCPR })
- Name (_DSD, Package (0x04) // _DSD: Device-Specific Data + Name (_DSD, Package (0x04) { ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), Package (0x01) diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index 1b9e952..6874d17 100755 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -89,4 +89,6 @@ // Mainboard specific #include "acpi/mainboard.asl"
+ /* camera */ + #include "acpi/mipi_camera.asl" }