Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29925 )
Change subject: nb/intel/gm45: Make fetching the blc_pwm freq global ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c@44 PS1, Line 44: char edid_ascii_string[EDID_ASCII_STRING_LENGTH + 1]; static?
https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c@673 PS1, Line 673: int get_blc_pwm_freq_value(void) Alternative to caching the string: Call it with NULL for the VBT stuff and make the check below:
if (blc_pwm_freq > 0 || !edid_ascii_string)
Reasoning: If the lookup would succeed `blc_pwm_freq` would already be set, if not, there's no need to try again.