build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm/virtual.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/arch/ar... PS2, Line 58: * fault when accessed for the first time */ \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/curses.h:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 955: #define wstandout(win) (wattrset(win,A_STANDOUT)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 956: #define wstandend(win) (wattrset(win,A_NORMAL)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/form/form.h:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 115: unsigned short status; /* flags */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ function definition argument 'const void *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 320: bool (* const prev_choice)(FIELD *,const void *)); space required after that ',' (ctx:OxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/form/fty_regex.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 67: #define INIT register char *sp = RegEx_Init(instring); macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/menu/m_global.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 72: ' ', /* Pad character */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/ge... File payloads/libpayload/libc/getopt_long.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/ge... PS2, Line 83: #define INORDER (int)1 Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... File payloads/libpayload/libc/qsort.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... PS2, Line 43: size_t i = (n) / sizeof (TYPE); \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... PS2, Line 73: #define vecswap(a, b, n) if ((n) > 0) swapfunc(a, b, n, swaptype) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects