Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47235 )
Change subject: drivers/i2c/rx6110sa: Add basic ACPI support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... File src/drivers/i2c/rx6110sa/rx6110sa.c:
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... PS3, Line 180: .speed = config->bus_speed ? : I2C_SPEED_FAST,
so 1hz is fast and 0hz is not?
If there is nothing defined in config->bus_speed (bus_speed=0), then the maximum supported bus speed of the RTC (I2C_SPEED_FAST = 400000,) is stored here. Otherwise the devicetree-value will be used to allow mainboard to override the speed if needed. Should I add a check to make sure the devicetree value is a valid one?
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... PS3, Line 205: /* Use name specified in config or take a fixed name. */
it always used a fixed name, no?
Oh, left-over from the previous patchset, will remove.