Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38343 )
Change subject: mb/pcengines/apu1/mainboard.c: Add SMBIOS type 16 and 17 entries ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu... PS3, Line 183: unsigned long *current) Does this fit in 96 chars?
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu... PS3, Line 211: unsigned long *current) Same here
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu... PS3, Line 231: agesa_dmi->T17[0][0][0].DeviceLocator); And here
https://review.coreboot.org/c/coreboot/+/38343/3/src/mainboard/pcengines/apu... PS3, Line 255: unsigned long *current) This one definitely fits