Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39263 )
Change subject: intel/soc: tgl, icl,cnl,apl,skl: add INTRUDER relevant registers
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39263/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39263/4//COMMIT_MSG@7
PS4, Line 7:
Remove for consistency?
https://review.coreboot.org/c/coreboot/+/39263/4//COMMIT_MSG@7
PS4, Line 7: tgl, icl,cnl,apl,skl
Ordered from new to old? Maybe alphabetically?
https://review.coreboot.org/c/coreboot/+/39263/4//COMMIT_MSG@10
PS4, Line 10:
What datasheet are they documented in?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If12d21e8e6721abb877cbbfbbba8f0127a86d96b
Gerrit-Change-Number: 39263
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Mar 2020 13:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment