2 Feb
2020
2 Feb
'20
1:11 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38670 )
Change subject: asus/p2b-*: Move serial init to mainboard bootblock ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38670/2/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/romstage.c:
https://review.coreboot.org/c/coreboot/+/38670/2/src/northbridge/intel/i440b... PS2, Line 17: #include <console/console.h> This header isn't needed anymore, I guess?
--
To view, visit https://review.coreboot.org/c/coreboot/+/38670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f3ee68e7c76a8c6db6d75956e6a7fb75ef83850
Gerrit-Change-Number: 38670
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment