build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )
Change subject: /mainboard/pcengines/apu2: implement POSTCAR_STAGE ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32363/2/src/mainboard/pcengines/apu2/BiosCal... File src/mainboard/pcengines/apu2/BiosCallOuts.c:
https://review.coreboot.org/#/c/32363/2/src/mainboard/pcengines/apu2/BiosCal... PS2, Line 100: // Disable DEVSLP0 and 1 to make sure GPIO55 and 59 are not used by DEVSLP line over 80 characters
https://review.coreboot.org/#/c/32363/2/src/mainboard/pcengines/apu2/state_m... File src/mainboard/pcengines/apu2/state_machine.c:
https://review.coreboot.org/#/c/32363/2/src/mainboard/pcengines/apu2/state_m... PS2, Line 80: AGESA_STATUS AmdGetValue(IN CONST AGESA_FIELD_NAME name, IN OUT VOID **value, IN UINT32 size) line over 80 characters
https://review.coreboot.org/#/c/32363/2/src/mainboard/pcengines/apu2/state_m... PS2, Line 80: AGESA_STATUS AmdGetValue(IN CONST AGESA_FIELD_NAME name, IN OUT VOID **value, IN UINT32 size) need consistent spacing around '*' (ctx:WxO)