build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41937 )
Change subject: northbridge/intel/broadwell: Add header files ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41937/5/src/northbridge/intel/broad... File src/northbridge/intel/broadwell/broadwell.h:
https://review.coreboot.org/c/coreboot/+/41937/5/src/northbridge/intel/broad... PS5, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/41937/5/src/northbridge/intel/broad... PS5, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/41937/5/src/northbridge/intel/broad... PS5, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + x)) Macros with complex values should be enclosed in parentheses