Attention is currently required from: Sam McNally, Martin Roth, Furquan Shaikh, Bhanu Prakash Maiya, Eric Peers.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50416 )
Change subject: mb/google/zork: modify ELAN TS i2c IRQ to LEVEL active for dirinboz
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/zork/variants/dirinboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50416/comment/0a18980d_b6191e13
PS4, Line 93: register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)"
Should this change to level too?
yes, it's modified in another one:
50420: mb/google/zork: modify ELAN TP i2c IRQ to LEVEL active for dirinboz | https://review.coreboot.org/c/coreboot/+/50420
thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbbc73b37932ba1359ffe6f572a15564bb341025
Gerrit-Change-Number: 50416
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Tue, 09 Feb 2021 09:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment