Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Simon Chou, TimLiu-SMCI, Christian Walter, Angel Pons, Arthur Heymans, Jian-Ming Wang, Tim Chu, Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 )
Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
The diff between the original nb_acpi.c and the new uncore_acpi.c is not shown. […]
nb_acpi.c is removed and unified in the newly added uncore_acpi.c, gerrit is not easy to review the differences, but if I cherry-pick it and use 'git show, it can show the differences made to nb_acpi.c and uncore_acpi.c directly for easier review:
git log --stat
src/soc/intel/xeon_sp/{nb_acpi.c => uncore_acpi.c}
git show
diff --git a/src/soc/intel/xeon_sp/nb_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c
similarity index 58%
rename from src/soc/intel/xeon_sp/nb_acpi.c
rename to src/soc/intel/xeon_sp/uncore_acpi.c
....
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf
Gerrit-Change-Number: 71958
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Fri, 03 Feb 2023 15:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment