Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )
Change subject: lib: hardwaremain: Call exception_init() as soon as possible
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c
File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c@457
PS1, Line 457: exception_init();
Place this after the post_code(POST_CONSOLE_READY)? In case things go wrong with exception init at l […]
Yes, it makes sense. I moved it after the post_code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab
Gerrit-Change-Number: 35022
Gerrit-PatchSet: 3
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 22 Aug 2019 04:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment